Add tests preventing .data access before .is_valid() in relation serializers #9845
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test_data_cannot_be_accessed_prior_to_is_valid to HyperlinkedManyToManyTests - Add test_data_cannot_be_accessed_prior_to_is_valid to PKManyToManyTests - Remove TODO comments that were addressed - Ensures AssertionError is raised when accessing .data before validation Fixes TODO items in: - tests/test_relations_hyperlink.py (line 71) - tests/test_relations_pk.py (line 97)
auvipy
approved these changes
Dec 9, 2025
browniebroke
approved these changes
Dec 9, 2025
Contributor
Author
|
Thank you for the reviews and approval. The PR is ready to merge, and I'm available for any further adjustments if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds tests to verify that attempting to access
serializer.databefore callingserializer.is_valid()correctly raises anAssertionErrorfor serializers involving relational fields.These tests address the missing coverage noted by TODO comments in:
tests/test_relations_hyperlink.pytests/test_relations_pk.pyChanges
test_data_cannot_be_accessed_prior_to_is_valid()to:HyperlinkedManyToManyTestsPKManyToManyTestsAPIRequestFactorywhere required to construct request instances.Rationale
Accessing
.dataprior to validation is inconsistent with DRF’s serializer lifecycle expectations. These tests ensure consistent behavior across relational serializers and protect against regressions.Testing
1612 passed, 4 skipped).This PR introduces no functional changes—only test coverage improvements.