fix: httpx.Client is slow when sending large data #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexianbin
force-pushed
the
fix/slow-for-big-body
branch
from
07d4d66 to
c7a8790
Compare
This commit addresses an issue where sending large data with httpx.Client was extremely slow. The problem was that the entire data payload was being loaded into memory and sent in a single operation. This fix refactors the sending process for iterable bytes types to use a chunked approach with `yield`, which significantly improves performance and reduces memory usage for large payloads. Signed-off-by: xiexianbin <me@xiexianbin.cn>
xiexianbin
force-pushed
the
fix/slow-for-big-body
branch
from
c7a8790 to
78377fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where sending large data with httpx.Client was extremely slow. The problem was that the entire data payload was being loaded into memory and sent in a single operation.
This fix refactors the sending process for iterable bytes types to use a chunked approach with
yield, which significantly improves performance and reduces memory usage for large payloads.Summary
test case ref encode/httpcore#1029, close issue #3660
Checklist