Add encore secret check command to validate environment secrets before deployment #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the folliowing configuration optons to infra-config: * database.name: Map the encore name to a database name * tls_config.disable_ca_validation: Disable CA validation for PSQL conns
Co-authored-by: Marcus Kohlberg <78424526+marcuskohlberg@users.noreply.github.com>
Co-authored-by: Simon Johansson <simon@encore.dev>
that came with rust 1.90
Since we need to build the jsruntime for this to work, I moved the e2e tests to its own job so that it runs in parallel. That job takes about the same time as the other test jobs, so hopefully it shouldnt add much time to ci. This also fixes error cause handling, it was duplicated
Dont create references if type constructors are already initialized
Co-authored-by: Fredrik Enestad <fredrik@enestad.com>
Just to make sure an app will start with this setting enabled
|
This pr contains 250 commits, I think there might be something wrong, you probably want to rebase on latest main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
27 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new CLI command encore secret check [envs...] that helps detect missing secrets across specified environments (e.g., prod, dev) before deployment.
The main goal is to prevent late feedback loops caused by missing secrets during deployment — for example, when a secret is set in the development environment but not in production.
By integrating this command into GitHub Workflows, it becomes possible to automatically verify that all required secrets are configured for each environment before merging a PR or triggering a deployment.
added new CLI command:
encore secret check [envs...]
Example Usage:
encore secret check prod dev
Output:
Secret Key Production Development
MySecret ✗ ✓
Error: There is 1 secret missing.
Successfully updated secret value for MySecretKey.
C:\Users\muges\myfolder\devday\encore\encore>encore secret list
Secret Key Production Development Local Preview Specific Envs
MySecretKey ✓ ✓ ✓ ✓
successfully solved
