runtimes/core: Add metrics #2109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
|
actually, I will refactor this a bit since metrics-rs isn't flexible enough with the different types that we support. Drafting this for now |
fredr
force-pushed
the
fredr/ts-metrics
branch
from
1f5a82a to
333ecb2
Compare
|
refactored and added system metrics to this ps |
fredr
changed the title
eandre
reviewed
Oct 21, 2025
runtimes/core/src/metrics/manager.rs
Outdated
| ) -> Arc<dyn Exporter + Send + Sync> { | ||
| match self { | ||
| Self::Gcp(config) | Self::EncoreCloud(config) => { | ||
| runtime_handle.block_on(Self::create_gcp_exporter(config, env, http_client)) |
There was a problem hiding this comment.
A bit annoying to need to block here. I guess the only reason we need to do that is because the container metadata needs to be collected? Can we do that lazily/in the background, similar to the lazy gcp client?
There was a problem hiding this comment.
I refactored to using a lazy cached client and avoiding the block_on by fetching the container data in the collect step
fredr
force-pushed
the
fredr/ts-metrics
branch
from
c7fc1d1 to
2b617df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ground work for adding metrics to encore.ts, adds the e_requests_total counter for apps running in gcp/encore cloud that export metrics to gcp cloud monitoring.
Will add support for aws, datadog and prometheus in a follow up.
This also doesnt expose any sys metrics, will add that in a follow up pr as well.