Skip to content

Don't warn when BlockCode script extends parent script #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Don't warn when BlockCode script extends parent script #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion addons/block_code/block_code_node/block_code.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ func _get_configuration_warnings():
if get_parent() is BlockCode:
warnings.append("The parent must not be a BlockCode.")
if get_parent().script:
warnings.append("This BlockCode will override the existing script in the parent node.")
var parent_script_name: StringName = get_parent().script.get_global_name()
if not (parent_script_name and block_script and parent_script_name == block_script.script_inherits):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

warnings.append("This BlockCode will override the existing script in the parent node.")
if get_parent().find_children("*", "BlockCode", false).size() > 1:
warnings.append("The parent should only contain one BlockCode.")
if block_script and _get_custom_or_native_class(get_parent()) != block_script.script_inherits:
Expand Down