adding socket options apis in dynamic modules

[VivekSubr]

Commit Message:
Additional Description: Adding apis to setsockopt and getsockopt to dynamic modules abi... this is a use case un-supported by wasm filters.
Risk Level: Low, new apis
Testing: Tested manually, verified using pcap, test code is available here: https://github.com/VivekSubr/Client-Server/tree/main/proxy/envoy/dynamic_modules/dscp_filter
Docs Changes: NA? I think dynamic modules apis aren't documented function by function.
Release Notes: Added envoy_dynamic_module_callback_http_set_socket_option and envoy_dynamic_module_callback_http_get_socket_option to dynamic modules abi.

[agrawroh]

Thanks for the contribution, @VivekSubr! You'll have to also update the ABI Version SHA and expose the RUST bindings for this change :)

/wait

[agrawroh]

@VivekSubr Looks like it's missing coverage:

FAILED: Directories not meeting coverage thresholds:
  ✗ source/extensions/filters/http/dynamic_modules: 93.5% (threshold: 95.2%)

/wait

[VivekSubr]

Got all the PR checks to pass, attaching test pcap screenshot for reference,

This pcap was taken using this test code: https://github.com/VivekSubr/Client-Server/tree/main/proxy/envoy/dynamic_modules/dscp_filter

This filter, added via dynamic modules, sets http response header using 'x-dscp' header from request.

I think this is good to merge... @agrawroh

[agrawroh]

LGTM with some minor nits. Thanks!

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #42784 was synchronize by VivekSubr.

see: more, trace.

[VivekSubr]

rebased PR, fixed review comments... @agrawroh, @wbpcode please review and approve

[agrawroh]

cc @wbpcode Could you please take another look as Sr. Extension Maintainer?

[wbpcode]

Thanks for the contribution. I think we merged related support for network filter recently. Could keep the same style with the network filter. I think it should be

envoy_dynamic_module_callback_http_set_socket_option_int
envoy_dynamic_module_callback_network_set_socket_option_bytes
envoy_dynamic_module_callback_network_get_socket_option_int
envoy_dynamic_module_callback_network_get_socket_option_bytes

It should be easy to keep the same style after merged main. Thanks again for this contribution.

/wait

[wbpcode]

cc @agrawroh because @agrawroh added the network socket option support.

[VivekSubr]

@wbpcode, @agrawroh ... didn't quite get this comment - so you want two variants of getter where it returns the option rather than filling the out parameter? But what would the setter return?

[agrawroh]

@wbpcode, @agrawroh ... didn't quite get this comment - so you want two variants of getter where it returns the option rather than filling the out parameter? But what would the setter return?

@VivekSubr We recently added this for Network filter. Take a look at these four methods in the code:

envoy_dynamic_module_callback_network_set_socket_option_int
envoy_dynamic_module_callback_network_set_socket_option_bytes
envoy_dynamic_module_callback_network_get_socket_option_int
envoy_dynamic_module_callback_network_get_socket_option_bytes

And then add http versions similarly:

envoy_dynamic_module_callback_http_set_socket_option_int
envoy_dynamic_module_callback_http_set_socket_option_bytes
envoy_dynamic_module_callback_http_get_socket_option_int
envoy_dynamic_module_callback_http_get_socket_option_bytes