feat: Implement ZoneAware loadbalancing - ZoneAware Lb Config (splitup #6482) #6485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jukie <10012479+Jukie@users.noreply.github.com>
jukie
force-pushed
the
split-impl-zone-aware-routing
branch
from
7340dfc to
4e7f0c9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6485 +/- ##
==========================================
- Coverage 71.16% 71.15% -0.02%
==========================================
Files 220 220
Lines 37985 38022 +37
==========================================
+ Hits 27032 27054 +22
- Misses 9382 9394 +12
- Partials 1571 1574 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
jukie
changed the title
|
/retest |
|
/retest |
Signed-off-by: Jukie <10012479+Jukie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: Implement ZoneAware Lb Config
What this PR does / why we need it:
Implementation for
LoadBalancer.ZoneAwareAPI (Ref: #6154)This adds the internal logic to support explicit configuration for Envoy LocalityLbConfig. Leaving the API marked as hidden/not-implemented because this will depend on a followup for tracking the EnvoyProxy Endpoints in xDS but splitting those changes out since it's a fairly large change (See #6482).
This also replaces
DestinationSetting.ZoneAwareRoutingwithDestinationSetting.PreferLocalto consolidate under the new API field.Which issue(s) this PR fixes:
xRef #6025
Release Notes: No
(will add release note for whichever PR gets merged last)