Skip to content

feat: getting OIDC client ID from secret #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jul 16, 2025

This PRs adds support for using Secret as a source of the OIDC client ID.
Implement: #5153
Release note: yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner July 16, 2025 02:01
@zhaohuabing zhaohuabing marked this pull request as draft July 16, 2025 02:02
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (10baf87) to head (af304e3).

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 0.00% 16 Missing ⚠️
internal/gatewayapi/securitypolicy.go 52.63% 7 Missing and 2 partials ⚠️
internal/provider/kubernetes/indexers.go 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (26.31%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6532      +/-   ##
==========================================
- Coverage   71.09%   71.05%   -0.04%     
==========================================
  Files         220      220              
  Lines       37970    38006      +36     
==========================================
+ Hits        26993    27005      +12     
- Misses       9401     9423      +22     
- Partials     1576     1578       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing force-pushed the impl-5153 branch 3 times, most recently from bef930f to 46b687f Compare July 16, 2025 06:28
@zhaohuabing zhaohuabing marked this pull request as ready for review July 16, 2025 07:28
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 17, 2025
@arkodg arkodg requested a review from a team July 17, 2025 00:15
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing changed the title Impl: getting OIDC client ID from secret feat: getting OIDC client ID from secret Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants