-
Notifications
You must be signed in to change notification settings - Fork 514
fix: rename listener using its address and port #6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zhaohuabing
wants to merge
13
commits into
envoyproxy:main
Choose a base branch
from
zhaohuabing:fix-6534
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,677
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6544 +/- ##
==========================================
+ Coverage 70.77% 70.78% +0.01%
==========================================
Files 224 224
Lines 38614 38672 +58
==========================================
+ Hits 27328 27375 +47
- Misses 9695 9703 +8
- Partials 1591 1594 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e3755b
to
b32b48f
Compare
8ccca85
to
a6d9776
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the xDS listener is named after one of the owning Gateway Listeners. When multiple Gateway Listeners are configured listening on the same port, the generated xDS listener name is derived from a randomly selected Gateway Listener. This can cause unnecessary listener drains in Envoy if one of the Gateway Listeners is deleted or a new one is created using the same port.
This PR resolves the issue by naming the xDS listener based on its listening address and port, ensuring consistent naming even when multiple Gateways share the same port.
Notice: xDS listener is a de-fact API surface - it's used by
EnvoyPatchPolicy
andExtensionManager
to modify xDS resources, and users may rely on it for configuring metrics or monitoring. To avoid introducing breaking change in v1.5 ,this change is gated by theUseAddressAsListenerName
feature flag. This flag is disabled by default in v1.5, and it will be enabled in v1.6.This PR also:
ExtensionManager
can use them as a replacement of the previous listener name if the Gateway and Listener resource names are required in its mutation processing.fix: #6534
release-note: yes