CONNECT/CONNECT-UDP Encapsulation Support #1379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asingh-g
force-pushed
the
nighthawk-connect-support
branch
from
46c5e51 to
fbe6068
Compare
mum4k
added
the
waiting-for-changes
asingh-g
force-pushed
the
nighthawk-connect-support
branch
from
ca97948 to
eda8939
Compare
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
- Major .bazelrc update after envoyproxy/envoy#39755 - Not taking the upstream update `build:linux --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=gold` which breaks my local `ci/do_ci.sh build` with `clang-18: error: invalid linker name in argument '-fuse-ld=gold'` - `Http1PoolImpl` started taking an `OverloadManager` argument; created a `NullOverloadManager` in `NighthawkServerInstance` to be used for that Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com> Signed-off-by: asingh-g <abhisinghx@google.com>
- Major .bazelrc update after envoyproxy/envoy#39755 - Not taking the upstream update `build:linux --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=gold` which breaks my local `ci/do_ci.sh build` with `clang-18: error: invalid linker name in argument '-fuse-ld=gold'` - `Http1PoolImpl` started taking an `OverloadManager` argument; created a `NullOverloadManager` in `NighthawkServerInstance` to be used for that Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Update `ENVOY_COMMIT` and `ENVOY_SHA`. Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
asingh-g
force-pushed
the
nighthawk-connect-support
branch
from
e9b11d7 to
87f61fe
Compare
Signed-off-by: asingh-g <100796504+asingh-g@users.noreply.github.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
eric846
requested changes
Jul 9, 2025
asedeno
reviewed
Jul 11, 2025
| @@ -1,5 +1,7 @@ | |||
| #include "source/client/process_bootstrap.h" | |||
|
|
|||
| #include <semaphore.h> | |||
There was a problem hiding this comment.
Can we use the C++ semaphore header rather than the C semaphore.h header, or perhaps something from Abseil's synchronization library?
There was a problem hiding this comment.
I looked into std::semaphore and abseil's synchronisation libs, I am not convinced if they're meant for IPC. The pshared flag (PTHREAD_PROCESS_SHARED) in semaphore.h is what allows us to do inter process synchronisation and it looks to me that both of the alternatives use PTHREAD_PROCESS_PRIVATE
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
asingh-g
force-pushed
the
nighthawk-connect-support
branch
2 times, most recently
from
b0b330f to
47d662f
Compare
Signed-off-by: asingh-g <abhisinghx@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to load test Terminating HTTP CONNECT/CONNECT-UDP Proxies, I've implemented encapsulation by spinning up a second envoy as a subprocess and routing nighthawk's generated traffic through it.
Presently CONNECT-UDP is only supported for HTTP/2 in envoy, and CONNECT is supported for all of H1, H2 and H3 QUIC.
Therefore only following combinations are supported
H1,H2 over H1,H2,H3
and
H3 over H2
using a combination of the --protocol and --tunnel-protocol flags.