handle possible DST change within FloorTime() #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrddr
commented
May 11, 2024
There was a problem hiding this comment.
According to https://stackoverflow.com/questions/8558919/mktime-and-tm-isdst gp.Tm.tm_isdst = -1; can sometimes produce unexpected result - when the return value of FloorTime() is within that one hour in October/November when same Local time has 2 possible GMT interpretations. When calling FloorTime(unit=year/month/day), it is not a problem, but might potentially become a problem when called with unit==hour/minute/second.
|
Additionally made major ticks nicer looking (take into account 23h/25h days when a DST change happens within the viewport) before after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #256