Skip to content

Fix patternImage color overlay #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
astrokin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix patternImage color overlay #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c0b60f
Fix for flipped origins: iOS (top-left) vs CG (bottom-left).
astrokin Jun 5, 2024
a5ec1f7
Fix for flipped origins: iOS (top-left) vs CG (bottom-left).
astrokin Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...s/Instructions/Managers/Internal/OverlayStyleManager/TranslucentOverlayStyleManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class TranslucentOverlayStyleManager: OverlayStyleManager {
if show {
self.overlayLayer.removeFromSuperlayer()
self.overlayLayer.frame = overlay.bounds
self.fixColorFromPatternImageIfNeeded(for: self.overlayLayer)
self.overlayLayer.backgroundColor = self.color.cgColor
overlay.holder.layer.addSublayer(self.overlayLayer)
overlay.holder.backgroundColor = UIColor.clear
Expand Down Expand Up @@ -122,6 +123,7 @@ class TranslucentOverlayStyleManager: OverlayStyleManager {

let maskLayer = CALayer()
maskLayer.frame = overlayLayer.bounds
fixColorFromPatternImageIfNeeded(for: self.cutoutMaskLayer)
maskLayer.addSublayer(self.cutoutMaskLayer)
maskLayer.addSublayer(self.fullMaskLayer)

Expand Down Expand Up @@ -160,4 +162,16 @@ class TranslucentOverlayStyleManager: OverlayStyleManager {

return layer
}

/*
// Adjust for flipped origins between CG and iOS.
// iOS origin: top left. CG origin: bottom left.
// This fix ensures proper rendering of gradient images and cutout layers
// created with `init(patternImage image: UIImage)`.
*/
private func fixColorFromPatternImageIfNeeded(for layer: CALayer) {
if type(of: self.color) == NSClassFromString("UIDynamicPatternColor") {
layer.transform = CATransform3DMakeScale(1, -1, 1)
}
}
}