Accept components only with tags (without default) #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables support for component registrations that define only tagged variants without a default component. This allows more flexible component organization where a content type may only need tag-specific components.
Key changes:
- Made the
defaultproperty optional inComponentWithVariantstype - Updated type guard and helper functions to support optional default components
- Reorganized component lookup logic to handle missing base entries when tags are specified
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/optimizely-cms-sdk/src/render/componentRegistry.ts | Made default component optional in variant definitions and updated lookup logic to support tag-only component registrations |
| test/test-website/src/components/with-display-templates.tsx | Added test components ct6/ct7 and Component6/Component7 to demonstrate tag-only component registration |
| test/test-website/src/app/en/layout.tsx | Registered test components with tag-only configurations for ct6 and ct7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
__test__/test-website/src/components/with-display-templates.tsx
Outdated
Show resolved
Hide resolved
JohanPetersson
approved these changes
Nov 5, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…content-js-sdk into bugfix/CMS-46517-loose-tuples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows developers to define a component to a
ContentType:tagcombination without requiring to have the mappingContentType(without tag)