Optionally pass --gcc-install-dir option to clang
#88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows the selection of a particular toolchain, including an hermetic one. See also: https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-gcc-install-dir Without this option, clang selects the latest toolchain installed on the system, which is not necessarily the one used to build the code and can lead to inconsistencies. This patch is related to issue erenon#19
|
Thanks! |
Synss
added a commit
to Synss/rules_lint
that referenced
this pull request
Jul 23, 2025
Without the argument, clang (clang-tidy) discovers a gcc installation automatically on the system, for example, ``` % clang -v Ubuntu clang version 18.1.8 (++20240731024944+3b5b5c1ec4a3-1~exp1~20240731145000.144) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/11 Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/12 Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13 Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13 ``` However, users may want to switch off the discovery and specify a version, exactly. ``` % clang -v --gcc-install-dir=/usr/lib/gcc/x86_64-linux-gnu/12 Ubuntu clang version 18.1.8 (++20240731024944+3b5b5c1ec4a3-1~exp1~20240731145000.144) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/12 ``` This is especially relevant for, but not limited to, hermetic toolchains. See also This patch ports erenon/bazel_clang_tidy#88 to rules_lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows the selection of a particular toolchain, including an hermetic one.
See also:
https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-gcc-install-dir
Without this option, clang selects the latest toolchain installed on the system, which is not necessarily the one used to build the code and can lead to inconsistencies.
This patch is related to issue #19