Update chapter-06 exercise 4 #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 4 (AND R4, R4, #0) is redundant because line 6 (NOT R4, R2) will store the flipped value of R2 into R4, regardless of what value this register previously contained. Almost the same with line 5 (AND R5 R5 #0). No need to clear it, because line 8 (ADD R5 R1 R4) rewrites it anyway. What is the point of line 11 (ADD R0 R0 #0) ? 😄 If line 9 (BRn #4) and line 10 (BRp #1) false, R0 is already 0 and program should stop.