-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add warning to prevent flicker #5494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanchosk
wants to merge
4
commits into
esphome:current
Choose a base branch
from
sanchosk:patch-4
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix markdown formatting and grammar issues.
Apply this diff:
```yaml light: - platform: esp32_rmt_led_strip rgb_order: GRB pin: GPIOXX num_leds: 30 chipset: ws2812 name: "My Light"-Important note In some specific cases, the RMT component might cause flicker of longer LED strips. The fix seem to be to disable the wifi power saving by setting
+Important note: In some specific cases, the RMT component might cause flicker on longer LED strips. The fix seems to be disabling Wi-Fi power saving by setting power_save_mode to
nonein the Wi-Fi component.In content/components/light/esp32_rmt_led_strip.md around lines 20–22, fix the
markdown and wording: ensure the fenced code block is surrounded by a blank
line, change "The fix seem to be" to "The fix seems to be", capitalize "Wi-Fi"
everywhere, add a colon after "Important note", reword "flicker of longer LED
strips" to "flicker on longer LED strips", and format the power_save_mode value
as inline code and the Wi‑Fi component name consistently while keeping the
existing links.