-
Notifications
You must be signed in to change notification settings - Fork 920
Updated aht20 driver to use thread safe api from idf>=5.4. (AEGHB-1062) #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
378c8c8
3719c16
3e4c618
4f076d7
75b9060
e216318
57caca2
f97e3c8
fd72df9
e9727a7
da70eb5
addf33f
22cd170
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,2 @@ | ||
| idf_component_register( | ||
| SRCS "aht20.c" | ||
| INCLUDE_DIRS "include" | ||
| PRIV_INCLUDE_DIRS "priv_include" | ||
| REQUIRES "driver" | ||
| ) | ||
|
|
||
| include(package_manager) | ||
| cu_pkg_define_version(${CMAKE_CURRENT_LIST_DIR}) | ||
| idf_component_register(SRCS "aht20.c" | ||
| INCLUDE_DIRS "include") |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| menu "AHT20 : CONFIGURATION" | ||
|
|
||
| config AHT20_CHECK_CRC | ||
| bool "perform crc check on AHT20 readings" | ||
| help | ||
| CRC check to be performed on results or not?. | ||
| default n | ||
|
|
||
|
|
||
| config AHT20_I2C_CLK_SPEED | ||
| int "I2C clock speed" | ||
| default 100000 | ||
| range 1 400000 | ||
| help | ||
| Clock speed used for i2c communication by AHT20 device. | ||
| Limited to maximum of 400KHZ. | ||
jeetrohan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| endmenu | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,32 +1,90 @@ | ||||||||||
| [](https://components.espressif.com/components/espressif/aht20) | ||||||||||
| # aht20 | ||||||||||
|
||||||||||
| # aht20 | |
| [](https://components.espressif.com/components/espressif/aht20) | |
| # Component: AHT20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the indentation means here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However indicates a contrast, but I don't think there's any inconsistency between the preceding and following parts. Perhaps Next would be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
However, I would like to inform you that..
It was perfectly right to use 'however' in above context... because it not always represents inconsistency.
It is also used for adding a comment to what have been just said, although something is true.
It was supposed to reflect that .... although the user should follow the example.. but for those who don't want to.. here are basic guidelines.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| aht20_handle_t aht20_handle = aht20_create( my_i2c_bus_handle, AHT20_ADDRESS_LOW ); //addresses are in aht.h | |
| aht20_handle_t aht20_handle = aht20_create( my_i2c_bus_handle, AHT20_ADDRESS_LOW ); //addresses are in aht20.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i2c_busThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.