-
Notifications
You must be signed in to change notification settings - Fork 11
Qualtrics reporting #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
luxaritas
wants to merge
23
commits into
dev
Choose a base branch
from
feat/salhai-report
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Qualtrics reporting #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ones, which propogate their events to the original button
…detail to use name instead of object
In particular we want to avoid re-running eternascript constraints, which could be doing who knows what. In addition to unknown expectations they may have around only being called on certain user interactions, we also want to avoid setting an expectation that they'll be called regularly because that seems ripe for poor author decisions and later breakakge if we change something
This was due to two things: 1) Using the opqueue to trigger updatescore 2) In updatescore, we also use the opqueue for updating the melting point and dot plot for the specbox We only actually need to recheck constraints, so this also is a bit of an optimization
This is stacked on #852 |
For a stack diff: feat/observability...feat/salhai-report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Qualtrics reporting for Ribotree SAL/HAI seed grant user study
qualtrics-report
feature flag to enable reporter and disable sending the solution to the serverImplementation Notes
Testing
Created puzzle on dev with degscore and timer constraints, verifying it solves correctly and degscore constraint info logs via console reporter as expected. Also verified simple hairpin solves correctly