-
Notifications
You must be signed in to change notification settings - Fork 21.1k
trie: swap out the pools in StackTrie with an arena allocator #32227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
773b0b2
trie: swap out the pools in StackTrie with an arena allocator
omerfirmak c5b268c
eth/snap: track time spent on trie rebuilding
omerfirmak 3d40a60
Revert "eth/snap: track time spent on trie rebuilding"
omerfirmak ff5beb2
updates from gary
omerfirmak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright 2025 The go-ethereum Authors | ||
// This file is part of the go-ethereum library. | ||
// | ||
// The go-ethereum library is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU Lesser General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
// | ||
// The go-ethereum library is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU Lesser General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU Lesser General Public License | ||
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
package common | ||
|
||
// Arena is an allocation primitive that allows individual allocations | ||
// out of a page of items and bulk de-allocations of last N allocations. | ||
// The most common way of using an Arena is to pair it up with a sync.Pool | ||
// of pages. | ||
type Arena[T any] struct { | ||
used uint32 | ||
pages [][]T | ||
|
||
PageSize uint32 | ||
NewPage func() any | ||
ReleasePage func(any) | ||
} | ||
|
||
// Alloc returns the next free item on the arena | ||
// Allocates a new page if needed | ||
func (a *Arena[T]) Alloc() *T { | ||
pageIndex := a.used / a.PageSize | ||
pageOffset := a.used % a.PageSize | ||
if pageOffset == 0 { | ||
a.pages = append(a.pages, a.NewPage().([]T)) | ||
} | ||
a.used++ | ||
return &a.pages[pageIndex][pageOffset] | ||
} | ||
|
||
// Used returns the number of items that live on this arena | ||
func (a *Arena[T]) Used() uint32 { | ||
return a.used | ||
} | ||
|
||
// Reset rollsback the active set of live elements to the given number | ||
func (a *Arena[T]) Reset(to uint32) { | ||
a.used = to | ||
} | ||
|
||
// Release releases all the pages that the arena currently owns | ||
func (a *Arena[T]) Release() { | ||
for _, page := range a.pages { | ||
a.ReleasePage(page) | ||
} | ||
a.pages = nil | ||
a.used = 0 | ||
} | ||
omerfirmak marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.