Skip to content

trie: swap out the pools in StackTrie with an arena allocator #32227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions common/arena.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// Copyright 2025 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The go-ethereum library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

package common

// Arena is an allocation primitive that allows individual allocations
// out of a page of items and bulk de-allocations of last N allocations.
// The most common way of using an Arena is to pair it up with a sync.Pool
// of pages.
type Arena[T any] struct {
used uint32
pages [][]T

PageSize uint32
NewPage func() any
ReleasePage func(any)
}

// Alloc returns the next free item on the arena
// Allocates a new page if needed
func (a *Arena[T]) Alloc() *T {
pageIndex := a.used / a.PageSize
pageOffset := a.used % a.PageSize
if pageOffset == 0 {
a.pages = append(a.pages, a.NewPage().([]T))
}
a.used++
return &a.pages[pageIndex][pageOffset]
}

// Used returns the number of items that live on this arena
func (a *Arena[T]) Used() uint32 {
return a.used
}

// Reset rollsback the active set of live elements to the given number
func (a *Arena[T]) Reset(to uint32) {
a.used = to
}

// Release releases all the pages that the arena currently owns
func (a *Arena[T]) Release() {
for _, page := range a.pages {
a.ReleasePage(page)
}
a.pages = nil
a.used = 0
}
64 changes: 0 additions & 64 deletions trie/bytepool.go

This file was deleted.

Loading