Skip to content

Conversation

@jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 20, 2025

In this PR, aimed to do the below tasks:

  1. the --authrpc.jwtsecret in geth is file path, while jwtsecret in devp2p is a value, so change the document to use in the correct way
  2. set the required flags as required=true inside the variable definition

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGMT

@lightclient lightclient merged commit 116c916 into ethereum:master Oct 22, 2025
5 of 6 checks passed
@lightclient lightclient added this to the 1.16.6 milestone Oct 22, 2025
@jsvisa jsvisa deleted the devp2p-doc branch October 25, 2025 02:24
rjl493456442 pushed a commit to rjl493456442/go-ethereum that referenced this pull request Oct 28, 2025
This PR fixes some docs for the devp2p suite and uses the CLI library's required value instead of manually checking if required flags are passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants