Skip to content

Conversation

@jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 22, 2025

closes #32984

After some debugging, I found the flaky was failed of the mismatch of the baseline accounts, in the success test, it showed 52, in the flaky it showed 51:

--- FAIL: TestSizeTracker (0.09s)
    state_sizer_test.go:201: Account count mismatch: baseline(51) + tracked_changes = 131, but final_measurement = 132
    state_sizer_test.go:204: Account bytes mismatch: expected 6758, got 6798
FAIL

As the write buffer in pathdb.Default's async writing, after SnapshotCompleted(), the buffer maybe not fully flushed, then the baseline iterating maybe missed some data.

But in the final result, as we reopened the triedb, so all the buffer have been flushed into db, the result is matched.

Here we propose to reopen the triedb before the baseline iterating.

@jsvisa jsvisa requested a review from rjl493456442 as a code owner October 22, 2025 07:24
@rjl493456442 rjl493456442 added this to the 1.16.6 milestone Oct 22, 2025
@rjl493456442 rjl493456442 merged commit 3b80752 into ethereum:master Oct 22, 2025
5 of 6 checks passed
@jsvisa jsvisa deleted the state-size-ci branch October 22, 2025 15:03
rjl493456442 pushed a commit to rjl493456442/go-ethereum that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: TestSizeTracker

2 participants