core/state: fix the flaky TestSizeTracker #32993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32984
After some debugging, I found the flaky was failed of the mismatch of the
baselineaccounts, in the success test, it showed52, in the flaky it showed51:As the write buffer in
pathdb.Default's async writing, afterSnapshotCompleted(), the buffer maybe not fully flushed, then the baseline iterating maybe missed some data.But in the final result, as we reopened the triedb, so all the buffer have been flushed into db, the result is matched.
Here we propose to reopen the triedb before the baseline iterating.