Skip to content

core/rawdb: reduce allocations in *key methods #33006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

core/rawdb: reduce allocations in *key methods #33006

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e36d7
core/rawdb: reduce allocations in *key
MariusVanDerWijden Oct 23, 2025
0438323
core/rawdb: reduce allocations in *key
MariusVanDerWijden Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions core/rawdb/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ func accountSnapshotKey(hash common.Hash) []byte {

// storageSnapshotKey = SnapshotStoragePrefix + account hash + storage hash
func storageSnapshotKey(accountHash, storageHash common.Hash) []byte {
buf := make([]byte, len(SnapshotStoragePrefix)+common.HashLength+common.HashLength)
//len(SnapshotStoragePrefix) == 1
buf := make([]byte, 1+common.HashLength+common.HashLength)
n := copy(buf, SnapshotStoragePrefix)
n += copy(buf[n:], accountHash.Bytes())
copy(buf[n:], storageHash.Bytes())
Expand Down Expand Up @@ -352,34 +353,32 @@ func IsStorageTrieNode(key []byte) bool {
return ok
}

// filterMapRowKey = filterMapRowPrefix + mapRowIndex (uint64 big endian)
func filterMapRowKey(mapRowIndex uint64, base bool) []byte {
extLen := 8
if base {
extLen = 9
// len(filterMapRowPrefix) + extLen
key := make([]byte, 4+9)
copy(key[:4], filterMapRowPrefix)
binary.BigEndian.PutUint64(key[4:4+8], mapRowIndex)
if !base {
return key[0 : 4+8]
}
l := len(filterMapRowPrefix)
key := make([]byte, l+extLen)
copy(key[:l], filterMapRowPrefix)
binary.BigEndian.PutUint64(key[l:l+8], mapRowIndex)
return key
}

// filterMapLastBlockKey = filterMapLastBlockPrefix + mapIndex (uint32 big endian)
func filterMapLastBlockKey(mapIndex uint32) []byte {
l := len(filterMapLastBlockPrefix)
key := make([]byte, l+4)
copy(key[:l], filterMapLastBlockPrefix)
binary.BigEndian.PutUint32(key[l:], mapIndex)
// len(filterMapLastBlockPrefix) + len(uint32)
key := make([]byte, 4+4)
copy(key[:4], filterMapLastBlockPrefix)
binary.BigEndian.PutUint32(key[4:], mapIndex)
return key
}

// filterMapBlockLVKey = filterMapBlockLVPrefix + num (uint64 big endian)
func filterMapBlockLVKey(number uint64) []byte {
l := len(filterMapBlockLVPrefix)
key := make([]byte, l+8)
copy(key[:l], filterMapBlockLVPrefix)
binary.BigEndian.PutUint64(key[l:], number)
//len(filterMapBlockLVPrefix) + len(uint64)
key := make([]byte, 4+8)
copy(key[:4], filterMapBlockLVPrefix)
binary.BigEndian.PutUint64(key[4:], number)
return key
}

Expand All @@ -390,8 +389,8 @@ func accountHistoryIndexKey(addressHash common.Hash) []byte {

// storageHistoryIndexKey = StateHistoryStorageMetadataPrefix + addressHash + storageHash
func storageHistoryIndexKey(addressHash common.Hash, storageHash common.Hash) []byte {
totalLen := len(StateHistoryStorageMetadataPrefix) + 2*common.HashLength
out := make([]byte, totalLen)
// len(StateHistoryStorageMetadataPrefix) == 2
out := make([]byte, 2+2*common.HashLength)

off := 0
off += copy(out[off:], StateHistoryStorageMetadataPrefix)
Expand All @@ -416,8 +415,8 @@ func trienodeHistoryIndexKey(addressHash common.Hash, path []byte) []byte {

// accountHistoryIndexBlockKey = StateHistoryAccountBlockPrefix + addressHash + blockID
func accountHistoryIndexBlockKey(addressHash common.Hash, blockID uint32) []byte {
totalLen := len(StateHistoryAccountBlockPrefix) + common.HashLength + 4
out := make([]byte, totalLen)
// len(StateHistoryAccountBlockPrefix) + len(common.Hash) + len(uint32)
out := make([]byte, 3+common.HashLength+4)

off := 0
off += copy(out[off:], StateHistoryAccountBlockPrefix)
Expand All @@ -429,8 +428,8 @@ func accountHistoryIndexBlockKey(addressHash common.Hash, blockID uint32) []byte

// storageHistoryIndexBlockKey = StateHistoryStorageBlockPrefix + addressHash + storageHash + blockID
func storageHistoryIndexBlockKey(addressHash common.Hash, storageHash common.Hash, blockID uint32) []byte {
totalLen := len(StateHistoryStorageBlockPrefix) + 2*common.HashLength + 4
out := make([]byte, totalLen)
// len(StateHistoryStorageBlockPrefix) + 2*common.HashLength + len(uint32)
out := make([]byte, 3+2*common.HashLength+4)

off := 0
off += copy(out[off:], StateHistoryStorageBlockPrefix)
Expand Down