core/state: parallelize the account trie hash along with storages #33037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
PR: bench05, Master: bench06 PR is about 1ms ahead 
Bench05: accountUpdate is 2.87ms (accountUpdate covers the storageUpdate part) 
Summary: the performance change is negligible. I will let @jwasinger to decide merging it or not |
Contributor
|
Let's wait and see what the implementation of BAL state root verification using the changes in this PR as a base looks like. |
Contributor
|
It turns out that this isn't really useful in the optimized BAL state root calculation, and that branch no longer uses the same path for state root update as the execution of non-BAL blocks. So I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.