Skip to content

triedb/pathdb: use copy instead of append to reduce memory alloc #33044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

triedb/pathdb: use copy instead of append to reduce memory alloc #33044

wants to merge 1 commit into from
+6 −3

Conversation

@jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 29, 2025

use the storageKey helper func to reduce the dynamic memory alloc

@jsvisa
triedb/pathdb: use copy instead of append to reduce memory alloc
3c1443e 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from rjl493456442 as a code owner October 29, 2025 03:25
@rjl493456442
Copy link
Member

can you write a benchmark to demonstrate the allocation difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsvisa @rjl493456442