[DO NOT MERGE] Vitest blockchain test runner for coverage reports, BLS coverage attempt by including implementation code as well #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… msg for instructions) edit files to run in testRunnerVitest.spec.ts command: `npx vitest run ./test/tester/testRunnerVitest --coverage.allowExternal --coverage.enabled`
jochem-brouwer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to create a coverage report for BLS, by also including the implementation code (Noble) in the report. I have tried to add things to vitest such that it also adds
node_modules/@noble/curvesto the report output, but to no avail. The new WIP strategy is now instead to list noble as an inner package and let vitest generate a coverage report.This PR showscases (but is NOT intended to get merged) also a very dirty way to generate coverage from the blockchain tests. So we can directly run fixtures from EEST and generate a coverage report. If you want to change which tests are ran change this in
vm/test/tester/testRunnerVitest.spec.ts:dir: '../fixtures/blockchain_tests/prague/eip2537_bls_12_381_precompiles/bls12_g1add',(to some dir you want to test)To run coverage,
cd ./packages/vmand thenbash coverage.sh