[WIP] Turn into trait #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Needs to be rebased. |
jakelang
reviewed
Dec 6, 2018
jakelang
reviewed
Dec 6, 2018
jakelang
reviewed
Dec 6, 2018
Member
Author
|
This is an old branch I turned into a PR so that it is not just lost. We can close the PR if it makes sen. |
Member
|
@axic do you want to build on this? or just rewrite the PR |
Member
Author
|
It can be cleaned up if we agree on an approach. |
axic
force-pushed
the
turn-into-trait
branch
4 times, most recently
from
4142537 to
c8afdcd
Compare
axic
force-pushed
the
turn-into-trait
branch
2 times, most recently
from
d21dcb6 to
84fe70b
Compare
Member
Author
jakelang
reviewed
May 28, 2019
Member
Author
|
Updates properly with current types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.