Revert "Enable simpledrm support" #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 16ebb31. Simpledrm could only function with a simplefb, which conflicts with traditional framebuffer support (exported as /dev/fbX). However, the commit turns SIMPLEDRM to m, which means a system without a dedicated DRM device won't show anything on the display even if a firmware- initialized framebuffer is available until simpledrm is loaded. Unluckily, simpledrm carries no MODULE_DEVICE_TABLE for simplefb, which acts as a platform device. This makes systems without a dedicated DRM device impossible to react when booting eweOS. It's known that simpledrm sometimes causes strange performance degradation when used together with a dedicated DRM device, so building it into the kernel isn't an option, either. Let's revert the change until coming up with a better solution to have KMS available on framebuffer-only systems. Signed-off-by: Yao Zi <ziyao@disroot.org>
Member
Author
|
See #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 16ebb31.
Simpledrm could only function with a simplefb, which conflicts with traditional framebuffer support (exported as /dev/fbX). However, the commit turns SIMPLEDRM to m, which means a system without a dedicated DRM device won't show anything on the display even if a firmware- initialized framebuffer is available until simpledrm is loaded.
Unluckily, simpledrm carries no MODULE_DEVICE_TABLE for simplefb, which acts as a platform device. This makes systems without a dedicated DRM device impossible to react when booting eweOS. It's known that simpledrm sometimes causes strange performance degradation when used together with a dedicated DRM device, so building it into the kernel isn't an option, either.
Let's revert the change until coming up with a better solution to have KMS available on framebuffer-only systems.