Implement Pickler for serialization #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This pull request introduces new feature to the library: a
Picklerclass that enables the serialization of JavaScript objects into the Python pickle format. This complements the existingParserand makes the library a complete, two-way solution for handling pickle data in a JS/TS environment.Summary of Changes
Refactored
BufferReaderto use a sharedSizesenum.Sizesenum. This enum is now shared between the reader and writer.BufferWriterclass andIWriterinterface (src/writer.ts)BufferReader.Picklerclass (src/pickler.ts)null,boolean,number,string,bigint)Array,Object,Map) and correctly serializes them as Pythonlistanddict.Added tests for the
Picklerpickler.dump()->parser.parse()) for supported data types and protocols.Picklerand then successfully deserialize it using a standard Pythonpickle.loads.I'm excited about this contribution and believe it will be a valuable addition to the project. I'm happy to discuss any part of the implementation or make any necessary changes.
Thanks for your time and consideration.