#78 Upgrade metabase to v0.50.36 #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
commented
Jul 31, 2025
| MB_EXASOL_TEST_HOST=$EXASOL_HOST \ | ||
| MB_EXASOL_TEST_PORT=$EXASOL_PORT \ | ||
| MB_EXASOL_TEST_CERTIFICATE_FINGERPRINT=$fingerprint \ | ||
| MB_EXASOL_TEST_USER=$EXASOL_USER \ | ||
| MB_EXASOL_TEST_PASSWORD=$EXASOL_PASSWORD \ | ||
| MB_DEV_ADDITIONAL_DRIVER_MANIFEST_PATHS="$exasol_driver_dir/resources/metabase-plugin.yaml" \ | ||
| MB_ENCRYPTION_SECRET_KEY=$(openssl rand -base64 32) \ |
There was a problem hiding this comment.
Not required any more, breaks tests
| (mt/dataset exasol-dataset/one-timestamp-per-day | ||
| (mt/dataset exasol-dataset/one-ts-per-day |
There was a problem hiding this comment.
Long dataset name caused assertion error in Metabase, because table name was longer than 30 chars
Comment on lines
-118
to
-131
| (deftest substring->honeysql-test | ||
| (testing "substring without length argument" | ||
| (is (= #honeysql.types.SqlCall {:args ["arg" 4], :name :substring} (sql.qp/->honeysql :exasol [:substring "arg" 4])))) | ||
| (testing "substring with length argument" | ||
| (is (= #honeysql.types.SqlCall {:args ["arg" 4 6], :name :substring} (sql.qp/->honeysql :exasol [:substring "arg" 4 6]))))) | ||
|
|
||
| (deftest concat->honeysql-test | ||
| (testing "concat with single argument" | ||
| (is (= #honeysql.types.SqlCall {:args ["arg1"], :name :concat} (sql.qp/->honeysql :exasol [:concat "arg1"])))) | ||
| (testing "concat with two arguments" | ||
| (is (= #honeysql.types.SqlCall {:args ["arg1" "arg2"], :name :concat} (sql.qp/->honeysql :exasol [:concat "arg1" "arg2"])))) | ||
| (testing "concat with three arguments" | ||
| (is (= #honeysql.types.SqlCall {:args ["arg1" "arg2" "arg3"], :name :concat} (sql.qp/->honeysql :exasol [:concat "arg1" "arg2" "arg3"]))))) | ||
|
|
There was a problem hiding this comment.
sql.qp/->honeysql was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78