-
-
Couldn't load subscription status.
- Fork 160
Update the generator to swift 6.2 #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
|
I will take a look at the changes later today, but I can if you want, can I ask Jeremy to add you to the organization so the prs doesn't automatically close. |
I’d appreciate a review. I still need to sort out a newly surfaced issue. For the tests, I used Swift 6.2 feature of test names, but the CI doesn’t support Swift 6.2 yet. I’ll think about which option to choose — either temporarily revert to the old style of naming tests or update somehow to 6.2 without using prepared github actions.
Yes, would be great, thank you. |
What's done?
As part of updating the track to support Swift 6.2, some work has been done on the generator:
has been added. The minimum macOS version required to run the generator is now macOS 13, as mandated by the
swift-syntaxlibrary../bin/test_generatorscript has been updated to support the new argument list.README.mdhas been updated to reflect these changes.