Skip to content

Conversation

@Sencudra
Copy link
Contributor

@Sencudra Sencudra commented Oct 13, 2025

What's done?

As part of updating the track to support Swift 6.2, some work has been done on the generator:

  1. All dependencies have been updated to their latest versions. A native dependency on swift-argument-parser
    has been added. The minimum macOS version required to run the generator is now macOS 13, as mandated by the swift-syntax library.
  2. The code has been carefully rewritten in a safer, more modern, and more testable manner. The new implementation is covered by tests.
  3. The ./bin/test_generator script has been updated to support the new argument list.
  4. The Generator README.md has been updated to reflect these changes.

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 13, 2025
@github-actions
Copy link
Contributor

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@meatball133 meatball133 reopened this Oct 13, 2025
@meatball133
Copy link
Member

meatball133 commented Oct 13, 2025

I will take a look at the changes later today, but I can if you want, can I ask Jeremy to add you to the organization so the prs doesn't automatically close.

@Sencudra
Copy link
Contributor Author

Sencudra commented Oct 13, 2025

I will take a look at the changes later today

I’d appreciate a review. I still need to sort out a newly surfaced issue. For the tests, I used Swift 6.2 feature of test names, but the CI doesn’t support Swift 6.2 yet. I’ll think about which option to choose — either temporarily revert to the old style of naming tests or update somehow to 6.2 without using prepared github actions.

but I can if you want, can I ask Jeremy to add you to the organization so the prs doesn't automatically close.

Yes, would be great, thank you.

@Sencudra Sencudra closed this Oct 27, 2025
@Sencudra Sencudra deleted the support_swift_6_2 branch October 27, 2025 07:07
@Sencudra Sencudra restored the support_swift_6_2 branch October 27, 2025 07:09
@Sencudra Sencudra reopened this Oct 27, 2025
@Sencudra Sencudra marked this pull request as ready for review October 27, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants