Skip to content

Refactor getCharset function for conciseness and modern syntax #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor getCharset function for conciseness and modern syntax #557

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f86ea0
Refactor getCharset function for conciseness and modern syntax
Ayoub-Mabrouk Oct 30, 2024
742016d
Update lib/types/urlencoded.js
Ayoub-Mabrouk Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/types/urlencoded.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,13 @@ function createQueryParser (options, extended) {
* Get the charset of a request.
*
* @param {object} req
* @returns {string|undefined}
* @api private
*/

function getCharset (req) {
try {
return (contentType.parse(req).parameters.charset || '').toLowerCase()
} catch (e) {
return contentType.parse(req).parameters.charset?.toLowerCase()
} catch {
return undefined
}
}
Expand Down