Skip to content

Create GitHub Action CI file #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create GitHub Action CI file #31

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c4df8e
Create GitHub Action CI file
f-meloni Oct 23, 2021
8c12771
Update swift.yml
f-meloni Oct 23, 2021
b7cc309
Update dependencies
f-meloni Oct 23, 2021
4bbd45e
Update swift version
f-meloni Oct 23, 2021
6c08ae2
Update Package.swift
f-meloni Oct 25, 2021
346a854
Update xcodebuild
f-meloni Oct 25, 2021
da378c6
Update swift.yml
f-meloni Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: CI

on: [pull_request]

jobs:
build:
runs-on: macos-11
steps:
- uses: actions/checkout@v2
- run: gem install bundler
- run: bundle install
- run: npm install -g danger
- run: swift package generate-xcodeproj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate-xcodeproj is deprecated. We're now using xcodebuild directly through fastlane scan, which results in the following output:

[13:10:35]: $ set -o pipefail && cd WeTransferPRLinter/ && env NSUnbufferedIO=YES xcodebuild -scheme WeTransferPRLinter -destination 'platform=macOS' -resultBundlePath 'build/reports/WeTransferPRLinter.xcresult' -enableCodeCoverage YES -clonedSourcePackagesDirPath /Users/vagrant/git/.build build test | tee '/Users/vagrant/Library/Logs/scan/WeTransferPRLinter.log' | xcpretty  --report junit --output '/var/folders/g2/xnd8hpjs50v433gfrybz2nxh0000gn/T/junit_report20211025-1719-128l68k'

In other words, you can skip generating the Xcode project and just use xcodebuild directly on the package

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew was deprecated, but didn't know I could use xcodebuild directly, that is pretty cool! thank you :)

- run: xcodebuild test -scheme DangerSwiftCoverage-Package -derivedDataPath build/ -enableCodeCoverage YES | XCPRETTY_JSON_FILE_OUTPUT=result.json xcpretty -f `xcpretty-json-formatter`
- run: DEBUG="*" swift run danger-swift ci
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7 changes: 7 additions & 0 deletions .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...pm/xcode/package.xcworkspace/xcuserdata/franco.xcuserdatad/UserInterfaceState.xcuserstate
View file
Open in desktop
Binary file not shown.
66 changes: 66 additions & 0 deletions .swiftpm/xcode/xcuserdata/franco.xcuserdatad/xcschemes/xcschememanagement.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>SchemeUserState</key>
<dict>
<key>DangerDeps.xcscheme_^#shared#^_</key>
<dict>
<key>orderHint</key>
<integer>1</integer>
</dict>
<key>DangerSwiftCoverage-Package.xcscheme_^#shared#^_</key>
<dict>
<key>orderHint</key>
<integer>0</integer>
</dict>
<key>DangerSwiftCoverage.xcscheme_^#shared#^_</key>
<dict>
<key>orderHint</key>
<integer>2</integer>
</dict>
<key>SWXMLHashPlayground (Playground) 1.xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>5</integer>
</dict>
<key>SWXMLHashPlayground (Playground) 2.xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>6</integer>
</dict>
<key>SWXMLHashPlayground (Playground).xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>4</integer>
</dict>
<key>Test area (Playground) 1.xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>8</integer>
</dict>
<key>Test area (Playground) 2.xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>9</integer>
</dict>
<key>Test area (Playground).xcscheme</key>
<dict>
<key>isShown</key>
<false/>
<key>orderHint</key>
<integer>7</integer>
</dict>
</dict>
</dict>
</plist>
104 changes: 34 additions & 70 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.1
// swift-tools-version:5.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try setting this to 5.5?

// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription
Expand All @@ -14,23 +14,29 @@ let package = Package(
.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]), // dev
],
dependencies: [
.package(url: "https://github.com/danger/swift.git", from: "3.0.0"),
.package(name: "danger-swift", url: "https://github.com/danger/swift.git", from: "3.0.0"),
// Dev dependencies
.package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.35.8"), // dev
.package(url: "https://github.com/Realm/SwiftLint", from: "0.28.1"), // dev
.package(url: "https://github.com/f-meloni/Rocket", from: "1.0.0"), // dev
.package(url: "https://github.com/orta/Komondor", from: "1.0.0"), // dev
.package(url: "https://github.com/f-meloni/danger-swift-xcodesummary", from: "1.0.0"), // dev
.package(name: "DangerXCodeSummary", url: "https://github.com/f-meloni/danger-swift-xcodesummary", from: "1.0.0"), // dev
],
targets: [
.target(name: "DangerDependencies", dependencies: ["Danger", "DangerSwiftCoverage", "DangerXCodeSummary"]), // dev
.target(name: "DangerDependencies", dependencies: [
.product(name: "Danger", package: "danger-swift"),
"DangerSwiftCoverage",
"DangerXCodeSummary",
]), // dev
.target(
name: "DangerSwiftCoverage",
dependencies: ["Danger"]
dependencies: [
.product(name: "Danger", package: "danger-swift"),
]
),
.testTarget(
name: "DangerSwiftCoverageTests",
dependencies: ["DangerSwiftCoverage", "DangerFixtures"]
dependencies: ["DangerSwiftCoverage", .product(name: "DangerFixtures", package: "danger-swift")]
),
]
)
Expand Down
5 changes: 3 additions & 2 deletions Sources/DangerSwiftCoverage/XcodeBuild/XcresultBundleFinder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ enum XcresultBundleFinder: XcresultBundleFinding {
let testFolder = derivedDataFolder + "/Logs/Test/"

guard let xcresults = try? fileManager.contentsOfDirectory(atPath: testFolder).filter({ $0.split(separator: ".").last == "xcresult" }),
!xcresults.isEmpty else {
!xcresults.isEmpty
else {
throw Errors.xcresultNotFound
}

let xcresult = testFolder + xcresults.sorted(by: { (left, right) -> Bool in
let xcresult = testFolder + xcresults.sorted(by: { left, right -> Bool in
let leftModificationDate = fileManager.modificationDate(forFileAtPath: testFolder + left)?.timeIntervalSince1970 ?? 0
let rightModificationDate = fileManager.modificationDate(forFileAtPath: testFolder + right)?.timeIntervalSince1970 ?? 0

Expand Down