fix(enum): handle nullable enum when useEnums=true #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When OpenAPI specifications combine both
enum: [...]andnullable: true, the TypeScript codegen ignores the latter when we pass theuseEnums: trueparam to use enums instead of string unions (example below).useEnumsargument was implemented in feat: enum support #153Solution
useEnumsearly return.Petproperty for the unit testsExample
The
Catschema is defined as such:Before
With strings ✅
With enums ❌
After
With strings (no changes) ✅
With enums ✅