Skip to content

[APPAI-1733] Use head ref to create PR across repos #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[APPAI-1733] Use head ref to create PR across repos #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rudra/utils/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def update_content(self, branch_name: str, file_path: str, update_message: str,
current_sha, branch=f'refs/heads/{branch_name}')
return update['commit'].sha

def create_pr(self, branch_name: str, title: str, body: str) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same for update_content as well? It will be uniform.

def create_pr(self, head_ref: str, title: str, body: str) -> str:
"""Raise the PR to merge changes from branch to master."""
pr = self._repo.create_pull(title=title, body=body, head=f'refs/heads/{branch_name}',
pr = self._repo.create_pull(title=title, body=body, head=head_ref,
base=f'refs/heads/{self._master_ref}')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even you can consider taking a head ref for base.

return pr.number