Associate arms with experiment ids #4306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 17, 2025 08:07
…its weight is encoded into that GR (facebook#4212) Summary: With SQ always being added as part of a GR and with [this code block](https://fburl.com/code/pnmuwj71) no longer being there as of D80304993, I think we can completely deprecate the weight override –– it's a complication that I believe we don't use, that makes the code a lot harder to follow and the behavior –– hard to predict. I'd like to know if folks have any objections to this move, especially bletham, sdaulton, eonofrey, ItsMrLin, mgarrard, who may have found themselves needing this in notebook experiments (if you do, please help me understand the use cases) : ) Reviewed By: saitcakmak Differential Revision: D80968518
Summary: I believe this is a remnant of some logic that was necessary in the past but is no longer Reviewed By: mgarrard Differential Revision: D82565836
…ped) (facebook#4200) Summary: Pull Request resolved: facebook#4200 Differential Revision: D80175881
Summary: As titled, just a small refactor (individual changes commented inline) Differential Revision: D80968586
Differential Revision: D80208015
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating diff in D80208015. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D80208015