Consolidate MapData.from_multiple_map_data into MapData.from_multiple_data #4410
+23
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84066098. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4410 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 555 555
Lines 57453 57457 +4
=======================================
+ Hits 55253 55259 +6
+ Misses 2200 2198 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esantorella
force-pushed
the
export-D84066098
branch
from
c21236f to
a2bb2fb
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 8, 2025
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 8, 2025
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
esantorella
force-pushed
the
export-D84066098
branch
from
a2bb2fb to
ebd0b00
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 8, 2025
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
esantorella
force-pushed
the
export-D84066098
branch
2 times, most recently
from
5558101 to
66e034e
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 9, 2025
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
esantorella
force-pushed
the
export-D84066098
branch
from
66e034e to
6a5838c
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 9, 2025
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
…_data (facebook#4410) Summary: **Context**: The following very similar methods exist: * `Data.from_multiple_data`: Combines multiple `Data` (not MapData) into one `Data` * `MapData.from_multiple_data`: Converts any data arguments into `MapData` if they are not already and then calls `MapData.from_multiple_map_data` * `MapData.from_multiple_map_data`: Combines `MapData`s into one `MapData` **This PR**: * Removes `MapData.from_multiple_map_data`; `MapData.from_multiple_data` should now be used Reviewed By: Balandat Differential Revision: D84066098
esantorella
force-pushed
the
export-D84066098
branch
from
6a5838c to
633ceeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
The following very similar methods exist:
Data.from_multiple_data: Combines multipleData(not MapData) into oneDataMapData.from_multiple_data: Converts any data arguments intoMapDataif they are not already and then callsMapData.from_multiple_map_dataMapData.from_multiple_map_data: CombinesMapDatas into oneMapDataThis PR:
MapData.from_multiple_map_data;MapData.from_multiple_datashould now be usedDifferential Revision: D84066098