Add IMetric to storage layer #4736
Open
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: User using client API in OSS noticed that IMetric wasn't saved, see issue: facebook#4671 This adds IMetric to storage layer so OSS API is fully valid. I discussed with mpolson64 if this was intentional, and at the time it was, but i do think we should have this in storage just so tutorials are easy to interchangable use. Differential Revision: D90066636 Privacy Context Container: L1307644
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4736 +/- ##
==========================================
- Coverage 96.73% 96.72% -0.01%
==========================================
Files 582 582
Lines 60710 60721 +11
==========================================
+ Hits 58725 58734 +9
- Misses 1985 1987 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
User using client API in OSS noticed that IMetric wasn't saved, see issue: #4671
This adds IMetric to storage layer so OSS API is fully valid. I discussed with mpolson64 if this was intentional, and at the time it was, but i do think we should have this in storage just so tutorials are easy to interchangable use.
Differential Revision:
D90066636
Privacy Context Container: L1307644