Remove MultiTypeExperiment initializations, type hints #4741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90133604. |
Summary: Ahead of the storage rework we want to upstream MultiTypeExperiment behavior into Experiment so we can have a single SQLAlchemy base class (and thus table) for all experiments. Differential Revision: D90125626 Privacy Context Container: L1413903
Summary: As titled. Should be a no-op since these are still initialized as MultiTypeExperiment. Next diff will remove instantiations. Differential Revision: D90133237 Privacy Context Container: L1413903
Summary: As titled. All new usage should be via Experiment directly Differential Revision: D90133604 Privacy Context Container: L1413903
mpolson64
force-pushed
the
export-D90133604
branch
from
1b269db to
a843132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. All new usage should be via Experiment directly
Differential Revision:
D90133604
Privacy Context Container: L1413903