-
Notifications
You must be signed in to change notification settings - Fork 356
Update target trial selection logic to only consider trials with data for optimization config metrics #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgarrard
wants to merge
1
commit into
facebook:main
Choose a base branch
from
mgarrard:export-D90089411
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4742 +/- ##
==========================================
- Coverage 96.72% 96.72% -0.01%
==========================================
Files 582 582
Lines 60693 60745 +52
==========================================
+ Hits 58708 58757 +49
- Misses 1985 1988 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 6, 2026
… for optimization config metrics (facebook#4742) Summary: This updates target trial selection logic in the following ways: 1. We only consider trials that either (a) have data for *all* opt config metrics or (b) have data for *all* metrics -- previously if a trial had data for some opt config metrics it passed the check, but this partial data setup causes issues downstream 2. If there is no long run trial, we fallback to short run instead of not identifying a target trial 3. filters out "stale" trials, ie trials that were completed over 10 days ago -- hitting this point would be pretty far down our priority list, but was an idea ItsMrLin initially had that i thought was really interesting 4. lastly if no trials exist after stale is filtered out, use the stale ones anyway (necessary for benchmarking) 5. if we still can't find anything, it will return none Reviewed By: ItsMrLin Differential Revision: D90089411 Privacy Context Container: L1307644
c7b8f93 to
7211102
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 7, 2026
… for optimization config metrics (facebook#4742) Summary: This updates target trial selection logic in the following ways: 1. We only consider trials that either (a) have data for *all* opt config metrics or (b) have data for *all* metrics -- previously if a trial had data for some opt config metrics it passed the check, but this partial data setup causes issues downstream 2. If there is no long run trial, we fallback to short run instead of not identifying a target trial 3. filters out "stale" trials, ie trials that were completed over 10 days ago -- hitting this point would be pretty far down our priority list, but was an idea ItsMrLin initially had that i thought was really interesting 4. lastly if no trials exist after stale is filtered out, use the stale ones anyway (necessary for benchmarking) 5. if we still can't find anything, it will return none Reviewed By: ItsMrLin Differential Revision: D90089411 Privacy Context Container: L1307644
7211102 to
54551ac
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 7, 2026
… for optimization config metrics (facebook#4742) Summary: This updates target trial selection logic in the following ways: 1. We only consider trials that either (a) have data for *all* opt config metrics or (b) have data for *all* metrics -- previously if a trial had data for some opt config metrics it passed the check, but this partial data setup causes issues downstream 2. If there is no long run trial, we fallback to short run instead of not identifying a target trial 3. filters out "stale" trials, ie trials that were completed over 10 days ago -- hitting this point would be pretty far down our priority list, but was an idea ItsMrLin initially had that i thought was really interesting 4. lastly if no trials exist after stale is filtered out, use the stale ones anyway (necessary for benchmarking) 5. if we still can't find anything, it will return none Reviewed By: ItsMrLin Differential Revision: D90089411 Privacy Context Container: L1307644
54551ac to
be89b7a
Compare
… for optimization config metrics (facebook#4742) Summary: This updates target trial selection logic in the following ways: 1. We only consider trials that either (a) have data for *all* opt config metrics or (b) have data for *all* metrics -- previously if a trial had data for some opt config metrics it passed the check, but this partial data setup causes issues downstream 2. If there is no long run trial, we fallback to short run instead of not identifying a target trial 3. filters out "stale" trials, ie trials that were completed over 10 days ago -- hitting this point would be pretty far down our priority list, but was an idea ItsMrLin initially had that i thought was really interesting 4. lastly if no trials exist after stale is filtered out, use the stale ones anyway (necessary for benchmarking) 5. if we still can't find anything, it will return none Reviewed By: ItsMrLin Differential Revision: D90089411 Privacy Context Container: L1307644
be89b7a to
65a540f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This updates target trial selection logic in the following ways:
Differential Revision:
D90089411
Privacy Context Container: L1307644