Move sort_by_trial_index_and_arm_name to ax.core.data
#4743
+85
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: **Context**: `Experiment.lookup_data_for_trial` looks up a single trial's data, and `Experiment.lookup_data` has an argument `trial_indices`. Previously, it was somewhat useful to have both becauase it was faster to look up data for a single trial than to filter that trial's data from the full DataFrame, but this is no longer the case now that data is represented as a single data frame rather than a dict of DataFrames. So `Experiment.lookup_data_for_trial` is not adding value. **This PR**: * Removes `Experiment.lookup_data_for_trial` and updates call sites Reviewed By: saitcakmak Differential Revision: D89811675
Summary: It makes more sense there than in ax.core.base_trial.py Reviewed By: saitcakmak Differential Revision: D89894244
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89894244. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4743 +/- ##
==========================================
- Coverage 96.73% 96.72% -0.01%
==========================================
Files 582 582
Lines 60699 60693 -6
==========================================
- Hits 58716 58708 -8
- Misses 1983 1985 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in aa29dd8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It makes more sense there than in ax.core.base_trial.py
Reviewed By: saitcakmak
Differential Revision: D89894244