-
Notifications
You must be signed in to change notification settings - Fork 24.8k
fix: View component does not have a displayName #52688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D78512254. |
This PR adds support for react native 81: - replaces the renderer for the version that provides information about component sources - defines internal imports from react native for the new version note: when testing the new version of react native we came across a problem with the inspector, that requires a fix in the RN core, We opened a [pull request ](facebook/react-native#52688) to mitigate that ### How Has This Been Tested: - run and play with `react-native-81` test app that was added to test apps
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D78512254. |
@alanleedev merged this pull request in 5ef4106. |
This pull request was successfully merged by @filip131311 in 5ef4106 When will my fix make it into a release? | How to file a pick request? |
@filip131311 Thanks for the fix. This was just merged and we have a pick request for 0.81 here; reactwg/react-native-releases#1060 |
Thanks! |
Summary: Hello, I work on [Radon IDE](ide.swmansion.com) I encountered an issue while adding support for react native 81, this PR solves it: In facebook#51023 EvanBacon removed `displayName` filed from `View` component adding the following comment: >Remove displayName in favor of component name. I'm not 100% sure this is a full fallback but it is valid according to react/display-name eslint rule—https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md Unfortunately the Fabric renderer uses the `displayName` property to generate the name of the component for the inspector functionality and in absence of it generates a name that might be confusing to the end user: <img width="351" height="283" alt="Screenshot 2025-07-17 at 21 27 37" src="https://github.com/user-attachments/assets/852246aa-6586-4684-b80e-5d70b9678c6e" /> Problem is not specific to Radon and happens in chrome devtools as well: <img width="501" height="130" alt="Screenshot 2025-07-17 at 22 16 52" src="https://github.com/user-attachments/assets/3514dd02-59f7-473a-87b1-6ed325d2034c" /> This PR brings back the `displayName` property to fix that. [INTERNAL] [FIXED] - Bring back the displayName property to the View component Pull Request resolved: facebook#52688 Test Plan: - Run the application - open chrome devtools and navigate to "components" tab - before changes the View components would show up as `View_withRef` after they are named `View` Rollback Plan: Reviewed By: lunaleaps, cortinico Differential Revision: D78512254 Pulled By: alanleedev fbshipit-source-id: 46e4a224b09fe3fb938c055a675f687c86d7ddcb
Summary: Hello, I work on [Radon IDE](ide.swmansion.com) I encountered an issue while adding support for react native 81, this PR solves it: In #51023 EvanBacon removed `displayName` filed from `View` component adding the following comment: >Remove displayName in favor of component name. I'm not 100% sure this is a full fallback but it is valid according to react/display-name eslint rule—https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md Unfortunately the Fabric renderer uses the `displayName` property to generate the name of the component for the inspector functionality and in absence of it generates a name that might be confusing to the end user: <img width="351" height="283" alt="Screenshot 2025-07-17 at 21 27 37" src="https://github.com/user-attachments/assets/852246aa-6586-4684-b80e-5d70b9678c6e" /> Problem is not specific to Radon and happens in chrome devtools as well: <img width="501" height="130" alt="Screenshot 2025-07-17 at 22 16 52" src="https://github.com/user-attachments/assets/3514dd02-59f7-473a-87b1-6ed325d2034c" /> This PR brings back the `displayName` property to fix that. [INTERNAL] [FIXED] - Bring back the displayName property to the View component Pull Request resolved: #52688 Test Plan: - Run the application - open chrome devtools and navigate to "components" tab - before changes the View components would show up as `View_withRef` after they are named `View` Rollback Plan: Reviewed By: lunaleaps, cortinico Differential Revision: D78512254 Pulled By: alanleedev fbshipit-source-id: 46e4a224b09fe3fb938c055a675f687c86d7ddcb Co-authored-by: filip131311 <159789821+filip131311@users.noreply.github.com>
This pull request was successfully merged by @motiz88 in b58e5fa When will my fix make it into a release? | How to file a pick request? |
Summary: Hello, I work on [Radon IDE](ide.swmansion.com) I encountered an issue while adding support for react native 81, this PR solves it: In facebook#51023 EvanBacon removed `displayName` filed from `View` component adding the following comment: >Remove displayName in favor of component name. I'm not 100% sure this is a full fallback but it is valid according to react/display-name eslint rule—https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md Unfortunately the Fabric renderer uses the `displayName` property to generate the name of the component for the inspector functionality and in absence of it generates a name that might be confusing to the end user: <img width="351" height="283" alt="Screenshot 2025-07-17 at 21 27 37" src="https://github.com/user-attachments/assets/852246aa-6586-4684-b80e-5d70b9678c6e" /> Problem is not specific to Radon and happens in chrome devtools as well: <img width="501" height="130" alt="Screenshot 2025-07-17 at 22 16 52" src="https://github.com/user-attachments/assets/3514dd02-59f7-473a-87b1-6ed325d2034c" /> This PR brings back the `displayName` property to fix that. ## Changelog: [INTERNAL] [FIXED] - Bring back the displayName property to the View component Pull Request resolved: facebook#52688 Test Plan: - Run the application - open chrome devtools and navigate to "components" tab - before changes the View components would show up as `View_withRef` after they are named `View` Rollback Plan: Reviewed By: lunaleaps, cortinico Differential Revision: D78512254 Pulled By: alanleedev fbshipit-source-id: 46e4a224b09fe3fb938c055a675f687c86d7ddcb
Summary:
Hello, I work on Radon IDE I encountered an issue while adding support for react native 81, this PR solves it:
In #51023 @EvanBacon removed
displayName
filed fromView
component adding the following comment:Unfortunately the Fabric renderer uses the
displayName
property to generate the name of the component for the inspector functionality and in absence of it generates a name that might be confusing to the end user:Problem is not specific to Radon and happens in chrome devtools as well:
This PR brings back the
displayName
property to fix that.Changelog:
[INTERNAL] [FIXED] - Bring back the displayName property to the View component
Test Plan:
View_withRef
after they are namedView