skip bytecode support for hermes #52767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78750791 |
andrewdacenko
force-pushed
the
export-D78750791
branch
from
3998c7d to
e99be2e
Compare
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
Jul 23, 2025
Summary: Changelog: [Internal] Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly. Reviewed By: christophpurrer Differential Revision: D78750791
|
This pull request was exported from Phabricator. Differential Revision: D78750791 |
andrewdacenko
force-pushed
the
export-D78750791
branch
from
e99be2e to
b5b14e5
Compare
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
Jul 23, 2025
Summary: Changelog: [Internal] Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly. Reviewed By: christophpurrer Differential Revision: D78750791
|
This pull request was exported from Phabricator. Differential Revision: D78750791 |
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: facebook#52767 Changelog: [Internal] Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly. Reviewed By: christophpurrer Differential Revision: D78750791
andrewdacenko
force-pushed
the
export-D78750791
branch
from
b5b14e5 to
1b894ed
Compare
Summary: Changelog: [Internal] Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly. Reviewed By: christophpurrer, rubennorte Differential Revision: D78750791
andrewdacenko
force-pushed
the
export-D78750791
branch
from
1b894ed to
ba547b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78750791 |
|
This pull request was successfully merged by @andrewdacenko in 273c2d8 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 273c2d8. |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebook#52767 Changelog: [Internal] Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly. Reviewed By: christophpurrer, rubennorte Differential Revision: D78750791 fbshipit-source-id: 5b55bc9acbd6ee5aad874ad57607325cb1373c2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently tests that depend on hermes dev bytecode will fail because in OSS this case was not handled. We need to skip them for now before we integrate hermes compiler properly.
Differential Revision: D78750791