Update TurboModuleTestFixture to handle Promise types #52801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
force-pushed
the
export-D78871865
branch
from
33cf2d0 to
9b60662
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: facebook#52801 Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
9b60662 to
efaefeb
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
efaefeb to
c34e0f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
c34e0f7 to
cb17392
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
force-pushed
the
export-D78871865
branch
from
cb17392 to
fe5f7a8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: facebook#52801 Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
2 times, most recently
from
ace6228 to
582e863
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
582e863 to
083c931
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
083c931 to
e99b63b
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
e99b63b to
424c094
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2025
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
424c094 to
ea8caba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
christophpurrer
force-pushed
the
export-D78871865
branch
from
ea8caba to
4c9bce4
Compare
Summary: Changelog: [Internal] This adds utility functions and sample test cases to verify AsyncPromises in GTests Reviewed By: lenaic Differential Revision: D78871865
christophpurrer
force-pushed
the
export-D78871865
branch
from
4c9bce4 to
360ba25
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78871865 |
|
This pull request has been merged in c7c8ce0. |
|
This pull request was successfully merged by @christophpurrer in c7c8ce0 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This adds utility functions and sample test cases to verify AsyncPromises in GTests
Differential Revision: D78871865