Skip to content

Conversation

@rickhanlonii
Copy link
Member

Stacked on #34946

This should be a noop, now that the legacy renderers are not being sync'd.

@meta-cla meta-cla bot added the CLA Signed label Oct 22, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 22, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 22, 2025

Comparing: 90817f8...e819cfb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 605.41 kB 605.41 kB = 107.22 kB 107.22 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 664.38 kB 664.38 kB = 117.09 kB 117.09 kB
facebook-www/ReactDOM-prod.classic.js = 688.25 kB 688.25 kB = 121.13 kB 121.13 kB
facebook-www/ReactDOM-prod.modern.js = 678.67 kB 678.67 kB = 119.48 kB 119.49 kB
facebook-react-native/react-dom/cjs/ReactDOM-prod.js +3.10% 6.48 kB 6.68 kB +1.16% 1.81 kB 1.83 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js +3.10% 6.48 kB 6.68 kB +1.16% 1.81 kB 1.83 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +2.75% 16.74 kB 17.20 kB +3.72% 3.60 kB 3.74 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-dom/cjs/ReactDOM-prod.js +3.10% 6.48 kB 6.68 kB +1.16% 1.81 kB 1.83 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js +3.10% 6.48 kB 6.68 kB +1.16% 1.81 kB 1.83 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +2.75% 16.74 kB 17.20 kB +3.72% 3.60 kB 3.74 kB
facebook-react-native/react/cjs/React-dev.js = 52.61 kB 52.09 kB = 11.61 kB 11.54 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 675.63 kB 668.01 kB = 115.86 kB 114.54 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 597.95 kB 591.04 kB = 105.45 kB 104.30 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,165.77 kB 1,152.18 kB = 192.32 kB 190.51 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 669.70 kB 661.81 kB = 114.70 kB 113.38 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 592.45 kB 585.28 kB = 104.39 kB 103.23 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 1,149.50 kB 1,135.33 kB = 189.53 kB 187.59 kB
react-native/implementations/ReactFabric-profiling.fb.js = 463.00 kB 455.77 kB = 77.32 kB 76.14 kB
react-native/implementations/ReactFabric-dev.fb.js = 773.17 kB 760.76 kB = 122.48 kB 120.69 kB
react-native/implementations/ReactFabric-dev.js = 769.76 kB 757.28 kB = 123.00 kB 121.16 kB
react-native/implementations/ReactFabric-prod.fb.js = 387.71 kB 381.15 kB = 67.24 kB 66.11 kB
react-native/implementations/ReactFabric-profiling.js = 458.93 kB 450.55 kB = 77.17 kB 75.95 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 344.56 kB 337.97 kB = 59.93 kB 58.76 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 369.36 kB 362.19 kB = 63.29 kB 62.13 kB
react-native/implementations/ReactFabric-prod.js = 383.99 kB 376.39 kB = 66.40 kB 65.35 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 615.98 kB 603.76 kB = 98.61 kB 96.99 kB

Generated by 🚫 dangerJS against e819cfb

@rickhanlonii rickhanlonii force-pushed the rh/disable-legacy-mode-on branch from e928c3b to 0f7cbd3 Compare October 22, 2025 15:14
@rickhanlonii rickhanlonii merged commit dd53a94 into facebook:main Oct 27, 2025
240 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 27, 2025
Stacked on #34946

This should be a noop, now that the legacy renderers are not being
sync'd.

DiffTrain build for [dd53a94](dd53a94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants