feat: add TypeScript definitions for UAParser.js enums #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce TypeScript type definitions for UAParser.js version 2.0.0. This enhances type safety and autocompletion for enums related to browsers, CPUs, devices, vendors, engines, and operating systems in the project. These changes are made to improve developer experience and ensure consistent usage of the enums throughout the codebase.
faisalman
approved these changes
Dec 10, 2024
nanalucky
pushed a commit
to nanalucky/ua-parser-js
that referenced
this pull request
Feb 18, 2025
Introduce TypeScript type definitions for UAParser.js version 2.0.0. This enhances type safety and autocompletion for enums related to browsers, CPUs, devices, vendors, engines, and operating systems in the project. These changes are made to improve developer experience and ensure consistent usage of the enums throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce TypeScript type definitions for UAParser.js version 2.0.0. This fixes a typescript issue I was seeing when trying to use the
us-parser-js/enumssubmodule, as Typescript could not detect that it was a real directory without the.d.tsfile. So I added in the missing pieces! I don't think there is a test case I can add for this though. If I'm wrong please thread!Prerequisites
Type of Change
Bug fix for type definitions when importing the
enumssubmodule.Description
This was the original issue I found when I was trying to figure out why the types weren't getting picked up: #736
Test
Please describe the tests that you ran to verify your changes.
I don't think there are tests I can write for this specific case, if I'm wrong please let me know.
Impact
Does this PR introduce a breaking change? What changes might users need to make due to this PR?
Hopefully, no
Other Info