Remove node fetch usage #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbbrawer-twitch
commented
Jul 28, 2025
Comment on lines
+5
to
+6
| import type { Headers as FetchAPIHeaders } from "undici"; | ||
| import type { IncomingHttpHeaders } from "undici/types/header"; |
There was a problem hiding this comment.
The main change
faisalman
reviewed
Aug 1, 2025
|
Merged in 9e6dff6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Bug fix
Description
Removes the dependency on node-fetch which cause projects that import this package to also import node types.
Test
Just a type change so no additional tests were needed. Fixed one test that has an import to node-fetch.
Impact
Removes the dependence on node fetch which could affect projects relying on those types. However, 2.01 did not have this dependence.
Other Info
Open issue: #777