fix: fix ubuntu AWS headers and downgrade modernprobe-builder base image #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
The current installation method for AWS linux headers and tools is based on downloading them from `ports.ubuntu.com` or `archive.ubuntu.com`, and then installing them with `dpkg -i`. Unfortunately, the current implementation doesn't work, because AWS headers are split into two packages: for example, headers for kernel `6.5.0-1024-aws` are split into `linux-headers-6.5.0-1024-aws` and `linux-aws-6.5-headers-6.5.0-1024`; both must be installed in order for anything using headers to work. Fix this headers and tools using directly the package manager. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Pin `modernprobe-builder` base image to`fedora:39`. Fedora 39 is deprecated, but this ensures working BPF object files build to run our distro/kernel tests. In the future, we can upgrade this after we investigate more the issues related to modern `clang` versions. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
changed the title
Contributor
Author
|
/hold until CI is green |
Disable BPF tests for both `oraclelinux-5.4-x86_64` and `oraclelinux-5.15-aarch64`. The VMs rootfs are based on `oraclelinux:8` and `oraclelinux:9`, which unfortunately provide a too much recent clang version (clang 20). This version doesn't work well wil the kernel expectation, and results in failing legacy BPF tests. BPF tests are disabled through a new `skip_legacy_bpf_tests` property in machine specification (see `ansible-playbooks/group_vars/all/vars.yml`). The new mechanism works by disabling legacy BPF support if the property is defined and set to true. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
force-pushed
the
ekoops/fix-images
branch
from
d903c19 to
293073a
Compare
I conducted some tests and this machine seems to correctly work. Reintroduce it. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
This is a temporary solution to make ubuntu-6.5 tests available on aarch64. Unfortunately, the newer images don't work, due to the fact that internal VM networking is not properly configured: specifically, the VM is able to ask for networking configuration to the external dnsmasq service, but the configuration is, for some reason, re-set after OS booting. While we investigate this issue, use the working old image. Furtunately, the old image has a recent enough cmake version (3.27.4). Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
force-pushed
the
ekoops/fix-images
branch
from
293073a to
ab658f7
Compare
Contributor
Author
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues introduced with #108, and some other due to the need of rebuilding images. Specifically:
modernprobe-builderbase image tofedora:39It introduces some temporary mitigations:
oraclelinux-5.15-aarch64andoraclelinux-5.4-x86_64.ubuntu-6.5-aarch64For all aforementioned points, please see commits log messages.
Besides this, it modifies
arch/distro/kernMakefile targets behaviour to tag generated images and cleans up some Dockerfiles.Finally, it reintroduces
oraclelinux-3.10machine, as I conducted some tests and it seems to work now.