Skip to content

Add tests for reentrancy in _rentStorage function #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tests for reentrancy in _rentStorage function #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions src/IdGateway.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,26 @@ contract IdGateway is IIdGateway, Guardians, Signatures, EIP712, Nonces {
//////////////////////////////////////////////////////////////*/

function _rentStorage(
uint256 fid,
uint256 extraUnits,
uint256 payment,
address payer
uint256 fid,
uint256 extraUnits,
uint256 payment,
address payer
) internal returns (uint256 overpayment) {
overpayment = storageRegistry.rent{value: payment}(fid, 1 + extraUnits);

if (overpayment > 0) {
payer.sendNative(overpayment);
}
// Calculate the overpayment before making any external calls
uint256 amountToRent = 1 + extraUnits;
overpayment = payment - storageRegistry.price(amountToRent);

// Make the external call to rent storage
storageRegistry.rent{value: payment}(fid, amountToRent);

// Return the overpayment after the external call
if (overpayment > 0) {
(bool success, ) = payer.call{value: overpayment}("");
require(success, "Transfer failed");
}
}


receive() external payable {
if (msg.sender != address(storageRegistry)) revert Unauthorized();
}
Expand Down