docs: Update README to use module imports #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvesJorge
changed the title
AlvesJorge
changed the title
AlvesJorge
changed the title
Fdawgs
reviewed
Jul 9, 2025
gurgunday
reviewed
Jul 10, 2025
|
|
||
| fastify.register(require('@fastify/multipart')) | ||
| fastify.register(multipart) |
There was a problem hiding this comment.
I think it's better to await this
There was a problem hiding this comment.
Why? I want to understand for my own personal use as well.
@Fdawgs would you not agree that Modules is the way node is headed and the majority of new code is written with modules? I understand that the underlying code is in CJS (and other parts of the docs too) but that wouldn't be a deterrent. If we want to move forward change needs to be incremental and non-breaking! We couldn't possibly update it all at once :) |
is2ei
reviewed
Aug 15, 2025
| const { pipeline } = require('node:stream/promises') | ||
| import fastify from "fastify" | ||
| import fs from "node:fs" | ||
| import { pipeline } from "node:stream"; |
There was a problem hiding this comment.
Was /promises removed intentionally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
As the ESModules are the standard way to import/export modules in javascript, the README examples should reflect that :)