This repository was archived by the owner on Mar 23, 2020. It is now read-only.
Add io assignment #158
Draft
Add io assignment #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
After thinking a little about it, I would put all of the taks in separate paragraphs instead of putting them in a dense of tasks. They are sufficiently disparate in their end form and introduce a lot of semantics, maybe meriting more comments. E.g. introducing a BufferedReader to people that never though much about buffering. The code examples are really good! |
skade
suggested changes
Feb 18, 2020
| --- | ||
| == Tasks | ||
|
|
||
| * Find out, what type the variable f is. Either your IDE shows you, or you can assign a random type to the variable, and run the program. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Find out, what type the variable f is. Either your IDE shows you, or you can assign a random type to the variable, and run the program. | |
| * Find out what type the variable f is. Either your IDE shows you, or you can assign a random type to the variable, and run the program. |
skade
reviewed
Feb 18, 2020
|
|
||
| let mut buf_reader = BufReader::new(file); | ||
| let mut content_string = String::new(); | ||
| buf_reader.read_to_string(&mut content_string).unwrap(); |
Collaborator
There was a problem hiding this comment.
fn main() -> std::io::Result<()> would allow us to use ? instead of unwrap here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.